CommunityToolkit / CommunityToolkit/Tooling-Windows-Submodule
Why do you remove wasdk target when both "uwp, wasdk" are specified in `GenerateAllSolution.ps1`?
- Lingua principale
- C#
- Stelle
- 55
- Fork
- 19
- Merge medio
- 40m
- PR unite (30g)
- 1
Descrizione
### Describe the bug
I just wasted several hours trying to figure out why is my wasdk gallery project suddenly missing in the main toolkit project. And I finally found [this out](https://github.com/CommunityToolkit/Tooling-Windows-Submodule/blob/9f2cd6730a313e47fca61e53728d8c9f88cd8dad/GenerateAllSolution.ps1#L65). I don't understand what this comment is saying. And from my experience, the two gallery (the uwp, and wasdk) works perfectly in peace before.
And if that's a necessary change, you should [document it](https://github.com/CommunityToolkit/Windows/wiki/Quick-Start#building-the-entire-solution) clearly (and oh look even the screenshots is not reflecting the change), and also change the [`GenerateAllSolution.bat`](https://github.com/CommunityToolkit/Windows/blob/906519524a9dc61118f4f65fb727a3031ecf3ebf/GenerateAllSolution.bat#L3) to an option like:
- uwp, wasm
- wasdk, wasm
The current default value is just a confusing contradiction to what you did, and will keep others wasting more hours on this.
Oh and a more funny thing is, why removing `wasdk` target instead of `uwp` when `uwp` is considered dead?
### Steps to reproduce
```text
n/a
```
### Expected behavior
n/a
### Screenshots
_No response_
### Code Platform
- [x] UWP
- [x] WinAppSDK / WinUI 3
- [ ] Web Assembly (WASM)
- [ ] Android
- [ ] iOS
- [ ] MacOS
- [ ] Linux / GTK
### Windows Build Number
- [ ] Windows 10 1809 (Build 17763)
- [ ] Windows 10 1903 (Build 18362)
- [ ] Windows 10 1909 (Build 18363)
- [ ] Windows 10 2004 (Build 19041)
- [ ] Windows 10 20H2 (Build 19042)
- [ ] Windows 10 21H1 (Build 19043)
- [ ] Windows 11 21H2 (Build 22000)
- [ ] Other (specify)
### Other Windows Build number
_No response_
### App minimum and target SDK version
- [ ] Windows 10, version 1809 (Build 17763)
- [ ] Windows 10, version 1903 (Build 18362)
- [ ] Windows 10, version 1909 (Build 18363)
- [ ] Windows 10, version 2004 (Build 19041)
- [ ] Other (specify)
### Other SDK version
_No response_
### Visual Studio Version
_No response_
### Visual Studio Build Number
_No response_
### Device form factor
_No response_
### Additional context
_No response_
### Help us help you
Yes, I'd like to be assigned to work on this item.
Guida per i contributori
Apri la guida per i contributori
Direzione di ricerca
Inizia dalla riga 65 di GenerateAllSolution.ps1 e dalla riga 3 di GenerateAllSolution.bat per tracciare come vengono selezionati o rimossi i target uwp e wasdk. Confronta questo comportamento con le istruzioni di compilazione e gli screenshot di Quick Start; il lavoro è completo quando le combinazioni di target supportate, il comportamento predefinito e la documentazione sono coerenti.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- powershell
- Ambito
- build-system
- Tipo di issue
- Bug
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Stato di attività
- Ferma
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 35/100