CommandCodeAI / CommandCodeAI/command-code
Renderer rows silently corrupt Kitty APC graphics escapes — blocks inline images from mods
还没有人认领这个 Issue。
- 主要语言
- 没有语言数据
- 星标
- 4k
- 派生
- 350
- PR 合并指标
- 30 天内没有已合并 PR
描述
Summary
Mod renderer rows silently corrupt Kitty Graphics Protocol (APC) escape sequences, making inline images impossible from mods even though the docs promise row styling with raw codes (api.md: "style them with ansi escapes — picocolors, @commandcode/tui helpers, or raw codes"). SGR escapes survive; multi-line APC payloads do not. This bug blocks any cmd.ui.image()-style feature (see #633 §7) and any mod that talks to a terminal graphics protocol.
Repro (mod-side, minimal)
A mod registers a renderer whose first row is a complete kitty APC (\x1b_Gf=100,q=1,a=T,...;<base64>\x1b\\). The same bytes written directly to fd 1 draw the image; the same bytes returned as a renderer row never draw. Verified today on kitty 0.42 with a browser-rendered PNG (784×62), all in a live session:
| Delivery | Result |
|---|---|
writeSync(1, apc) from inside the renderer |
image draws |
| APC as first renderer row, 4096-byte payload | no image (row wraps at terminal width → sequence corrupted) |
APC split into 96-byte / 64-byte row chunks, chained with m=1/m=0 |
still no image |
Root cause (two layers)
- Wrap corruption: a KB-scale APC cannot fit one terminal line; the feed wraps long rows at the column width, splitting the sequence mid-payload. Kitty silently drops malformed graphics sequences when
q=1— no error reaches the mod or the user. - Chunk-chain interleaving: splitting into line-sized chunks per the protocol's own
m=continuation mechanism doesn't help either — the feed joins rows with\nand full-screen repaints can split the chain across writes, and interleaved bytes between continuation chunks invalidate the transmission (again silently).
The SGR-red-caption probe proved the pipe itself passes escapes — the chain specifically dies between chunks.
What would fix it
Either of:
- APC passthrough in the row pipeline — treat
\x1b_G…\x1b\\as an atomic zero-width unit in the width calculator and row sanitizer (the same allowance SGR already gets), so a chain of line-sized APCs rides the row stream intact. Mod-side we already chunk to 64-byte rows precisely for this. - A first-class image API — e.g.
cmd.ui.image({ path, rows })that owns protocol detection, chunking, placement, and repaint behavior (would supersede/fold into #633 §7cmd.ui.image(); this issue supplies the pipeline groundwork it needs).
Until then, mods must fall back to writing directly to fd 1, which draws the image but anchors it to whatever the cursor happens to be at render time — placement drifts relative to the feed block (phantom padding), and it breaks under scroll.
Environment
- Command Code 1.37.0 (npm global)
- kitty 0.42,
TERM=xterm-kitty, interactive TTY (graphics protocol verified working via raw fd write) - Repro mod:
kitty-graph-repro.ts(attached to this issue) — encoder, capability gate, and both delivery strategies; the Delivery A/B switch is a one-line change in the renderer
Related
- #633 §7 —
cmd.ui.image()feature request (the umbrella this bug blocks) - #609 — adjacent: feed rendering surface limitations for mods
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从附带的 kitty-graph-repro.ts 开始,检查 renderer 的行流水线,包括其宽度计算器和行清理器。比较直接写入 fd 与作为行返回的 APC,然后在所述 kitty 环境中验证,完整的 APC 序列和分块的 APC 序列在重绘过程中能够不发生损坏或交错地存续。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- typescript
- 领域
- cli
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 活跃
- 描述清晰度
- 基本清楚
- 新手友好度
- 45/100