Codeception / Codeception/module-webdriver
Default timeouts are set to zero, instead of 30 seconds
- 主要語言
- PHP
- 星號
- 39
- 分支
- 25
- PR 合併指標
- 30 天內沒有已合併 PR
描述
Hey Guys,
Here https://codeception.com/docs/modules/WebDriver Codeception claims, that default timeouts (`connection_timeout` and `request_timeout`) are 30 seconds. Because of the bug, I think they are set to 0 now, which makes curl_exec() later to wait indefinitely.
Check this code https://github.com/Codeception/module-webdriver/blob/master/src/Codeception/Module/WebDriver.php#L362
```
$this->connectionTimeoutInMs = $this->config['connection_timeout'] * 1000;
$this->requestTimeoutInMs = $this->config['request_timeout'] * 1000;
```
by default both values are `null`, but multipling `null * 1000` results in `0`, not `null`. Later here https://github.com/php-webdriver/php-webdriver/blob/main/lib/Remote/RemoteWebDriver.php#L101 it is strictly compared with `null`, but since the value is `0` it passes the condition and sets timeout to `0` which makes curl to wait indefinitely.
貢獻指南
這個儲存庫沒有索引到貢獻指南
評估
這個 Issue 還沒有評估資料。