Codeception / Codeception/module-webdriver

Default timeouts are set to zero, instead of 30 seconds

Open
#16 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
39
Forks
25
PR merge metrics
No merged PRs in 30d

Description

Hey Guys,

Here https://codeception.com/docs/modules/WebDriver Codeception claims, that default timeouts (`connection_timeout` and `request_timeout`) are 30 seconds. Because of the bug, I think they are set to 0 now, which makes curl_exec() later to wait indefinitely.

Check this code https://github.com/Codeception/module-webdriver/blob/master/src/Codeception/Module/WebDriver.php#L362
```
$this->connectionTimeoutInMs = $this->config['connection_timeout'] * 1000;
$this->requestTimeoutInMs = $this->config['request_timeout'] * 1000;
```
by default both values are `null`, but multipling `null * 1000` results in `0`, not `null`. Later here https://github.com/php-webdriver/php-webdriver/blob/main/lib/Remote/RemoteWebDriver.php#L101 it is strictly compared with `null`, but since the value is `0` it passes the condition and sets timeout to `0` which makes curl to wait indefinitely.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.