Codeception / Codeception/module-webdriver
Suggestion: Make `amOnPage()` wait for JavaScript to finish by default
- Langage dominant
- PHP
- Étoiles
- 39
- Forks
- 25
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
Starting point: Everybody always wants JavaScript to finish, before performing any action/assertion on the page, right?
At least my usual pattern is:
```php
$I->amOnPage('/');
$I->waitForJS('return document.readyState === "complete";', 5); // https://gist.github.com/pastuhov/43674b195dc293ffd847
```
So I thought about ways to simplify this. My first idea was to introduce a new method, something like `waitForJSToComplete()`.
But now, I think it's even better to include this in `amOnPage()`, by introducing a second parameter:
```php
public function amOnPage($page, bool $waitTillJSIsComplete = true): void
```
This would be a BC break.
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Évaluation
Cette issue n'a pas encore été évaluée.