Codeception / Codeception/module-phalcon4

SessionManager methods missing

Ouverte
#13 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
PHP
Étoiles
3
Forks
8
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

When my tests tried to run a test that involved a session destroy, I got an error. Because `MemorySession.php` doesn't actually start the session using `session_start`, `session_destroy` doesn't work either.

Also, `MemorySession.php`'s get and set methods aren't actually used, because the get and set are called from `SessionManager.php`.

I fixed this by adding methods to `SessionManager.php`:

```php
class SessionManager extends Manager
{
//...

public function destroy(): void
{
$this->getAdapter()->destroy($this->getId());
}

public function get(string $key, $defaultValue = null, bool $remove = false)
{
return $this->getAdapter()->get($key, $defaultValue, $remove);
}

public function set(string $key, $value): void
{
$this->getAdapter()->set($key, $value);
}
}

```

Please let me know if this is correct, or if I'm missing something.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.