Codeception / Codeception/module-laravel

Disable Laravel exception handling

Open
#2 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
6
Forks
13
PR merge metrics
No merged PRs in 30d

Description

Laravel v7.10.3

I was trying to `$i->disableExceptionHandling()` and noticed that it wasn't actually getting taken care of. I would gladly PR this as it seems like a simple change:

https://github.com/Codeception/module-laravel5/blob/bd2c604e8aa02d2b24737de01c6716473e8db96c/src/Codeception/Lib/Connector/Laravel5/ExceptionHandlerDecorator.php#L74

Any objections to removing the 2nd condition from the if statement? From a "disable exception handling" standpoint I don't care if it's a laravel or symfony exception, I just want it to get re-thrown.

Any objections to this change?

It looks like @janhenkgerritsen is familiar with these issues in some capacity, so I am tagging for visibility!

Contributor guide

Open the contributing guide

Research direction

Open src/Codeception/Lib/Connector/Laravel5/ExceptionHandlerDecorator.php at the referenced condition around line 74 and trace how disableExceptionHandling affects exception rethrowing. Verify the behavior for Laravel and Symfony exceptions, then add or update the relevant test if the repository provides coverage; done means disabled handling rethrows the exception regardless of its framework type.

Written by the indexing model from the issue text.

Assessment

Tech stack
laravel, php
Domain
testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.