Codeception / Codeception/module-doctrine
Doctrine2 Module: Is `flush()` before checking the database so necessary?
- Dominant language
- PHP
- Stars
- 4
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Description
Why do we flush managed Doctrine entities before checking the database in [`Doctrine2::proceedSeeInRepository()`](https://github.com/Codeception/Codeception/blob/bd6ad8af1fa7cd12684f0287374b9fe71a8c958a/src/Codeception/Module/Doctrine2.php#L378)?
In functional tests the Entity Manager of application is used in the Codeception Doctrine2 Module. If we do test a request with validation rejection, and we want to be sure the database was not changed, the test result will be false negative (the request fetches and populates some entity, but didn't save changes to the database, and then `dontSeeInRepository()` flushes the invalid entity to the database and does fail).
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in src/Codeception/Module/Doctrine2.php at Doctrine2::proceedSeeInRepository(), especially the flush before the database check. Review the issue's validation-rejection scenario and existing module tests, then verify that checking repository contents does not persist fetched or invalid managed-entity changes; the relevant tests should pass without false negatives.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- databases, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100