Codeception / Codeception/module-db
inserting null on an autoincrement primary key prevents cleanup
- Dominant language
- PHP
- Stars
- 23
- Forks
- 31
- PR merge metrics
- No merged PRs in 30d
Description
When I have a table with a primary key column that's also increment, it's valid to set it to `null` on the insert statement. the last insert it will then return the auto increment value, which is the primary key in that case.
As already noticed in #44, the auto increment column doesn't have to be part of the primary key, so the return value of last insert id ironically doesn't necessarily belong to the primary key. However, #44 also broke the case, which one might perceive as more common, that the last insert id may also be the primary key.
So, `haveInDatabase(table, ['id' => null, ...])` with id as autoincrement and pk will lead to the id being set to `null` for cleanup, which results in the row not being removed at teardown.
I have prepared a fix for this case, which hopefully is specific enough to not interfere with other use cases.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by reproducing the haveInDatabase(table, ['id' => null, ...]) case with an autoincrement primary key, then trace how the inserted ID is recorded for teardown cleanup. Done means the generated primary-key value is retained and the inserted row is removed during cleanup without breaking cases where the autoincrement column is not the primary key.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- databases, testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100