Codeception / Codeception/lib-xml

Xml::arrayToXml fails on nested arrays

未關閉 適合新手
#7 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
PHP
星號
17
分支
1
PR 合併指標
30 天內沒有已合併 PR

描述

The helper function arrayToXml has code indended to handle nested arrays, but currently always throws PHP errors. This means nested arrays can't be used when testing soap functions with array data either.

### Reproduce

Code:

```PHP
$dom = new \DOMDocument();
$array = [
'foo' => [
'bar' => '1'
]
];
echo \Codeception\Util\Xml::arrayToXml($dom, $dom, $array)->saveXML();
```

Expected output:

```XML

1
```

Result:
```
Undefined property: DOMDocument::$foo
```

### Cause

When the function encounters an array, it calls itself to parse the array, with `$domNode->$el` as the new $domNode parameter. The problem is that that node `->$el` will never exist, since that's the node this function was supposed to create in the first place.

### Fix

Create a new element first, to pass to the recursive call, and then append that new node to the xml structure.

Current code:
```PHP
if (is_array($val)) {
self::arrayToXml($xml, $domNode->$el, $val);
} else {
$domNode->appendChild($xml->createElement($el, $val));
}
```

Fixed code:
```PHP
if (is_array($val)) {
$elementNode = $xml->createElement($el);
self::arrayToXml($xml, $elementNode, $val);
$domNode->appendChild($elementNode);
} else {
$domNode->appendChild($xml->createElement($el, $val));
}
```

Alternatively, we could make it a little more consistent by always creating and appending the element in the same way, and only set the value inside the if-condition. That code would look like this:
```PHP
$elementNode = $xml->createElement($el);
if (is_array($val)) {
self::arrayToXml($xml, $elementNode, $val);
} else {
$elementNode->nodeValue = $val;
}
$domNode->appendChild($elementNode);
```

Both solutions result in working code for nested arrays.

貢獻指南

這個儲存庫沒有索引到貢獻指南

研究方向

Start at the Xml::arrayToXml helper and reproduce the nested-array example from the issue. Inspect the recursive branch where the nested element is passed before it exists, then verify that the example produces the expected nested XML without PHP errors.

由索引模型根據 Issue 內容生成。

評估

技術堆疊
php
領域
testing-qa
Issue 類型
缺陷
難度
2/5
預估耗時
1-3 小時
活躍度
停滯
描述清晰度
描述清楚
新手友好度
65/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。