Codeception / Codeception/Codeception

seeCurrentUrlEquals is actually seeCurrentUriEquals (notice the last char in url and uri)

Aperta
#6,209 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
PHP
Stelle
4.9k
Fork
1.3k
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

#### What are you trying to achieve?
I'm trying to assert equal current URL

#### What do you get instead?
I get assertion for current URI not URL

### Details

* Codeception version: 4.1.20

I'm currently working on acceptance test which is trying to assert switches between domain and subdomains.

And I found that current method [seeCurrentUrlEquals](https://github.com/Codeception/module-webdriver/blob/ebbe729c630415e8caf6b0087e457906f0c6c0c6/src/Codeception/Module/WebDriver.php#L1277) is acually asserting equality of URI not URL. It should assert rather

```php
$currentUrl = $this->webDriver->getCurrentURL()
$this->assertEquals($url, $currentUrl);
```

And in that case WebDriver need to introduce new method `seeCurrentUriEquals` which will assert

`$this->assertEquals($uri, $this->_getCurrentUri());`

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.