CodeYourFuture / CodeYourFuture/Module-Data-Flows

TV Show Project Level 300: Swap back to your old codebase

Ouverte
#477 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
🏕 Priority Mandatory 📅 Sprint 2 Core Submit:None
Langage dominant
JavaScript
Étoiles
0
Forks
275
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

# Level 300

For level 300, you should switch back to your original codebase.

You should have reviewed and merged your partner's level 200 changes through a PR to your own repo.

Remember to pull the latest changes onto your local machine.

Once again, compare their implementation to yours. Think:
1. How is it different?
2. What do you prefer about your implementation?
3. What do you prefer about their implementation?
4. What did you learn that you didn't know before?

Have a discussion about your answers to these questions. In class, together, give a 3 minute talk about your conclusions.

## Refactoring

Like with level 200, feel free to change anything in your codebase which you think will make it easier to work with, or to build new features.

Make a branch and pull request for yourself, and then have your partner review, making sure they understand the changes made.

## Adding new functionality

Level 300 is about getting rid of our static data from `episodes.js`, and instead using an API.

### Requirements

1. You must delete the `episodes.js` file from your repository.
2. Your website must still work the same, but by using a `fetch` request to https://api.tvmaze.com/shows/82/episodes. This URL should serve the exact same content as was returned by `getAllEpisodes` in `episodes.js`.
3. You must fetch this URL only _once_ per visit to your website. You should not re-fetch when someone searches, scrolls, or selects an episode from the drop-down.
4. If you don't have data yet, you should show something to tell the user to wait for the data.
5. If an error occurred loading the data, notify the user.
1. Note: real users don't look in the console - `console.log` or `console.error` are not sufficient for this requirement.
2. You will need to simulate an error to test this out yourself.

### Documentation

You can see that this endpoint has been documented here: https://www.tvmaze.com/api#show-episode-list

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.