CodeForPhilly / CodeForPhilly/chime

Missing 1 hospitalized

Abierto
#352 1 comentario 0 reacciones 2 asignados Reclamado por @PhilMiller Ver en GitHub
bug python qa
Lenguaje dominante
Python
Estrellas
210
Forks
153
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Corey review, confirm, and suggest a solution.

There is an initial hospitalized patient because fitting was done for the date_first_hospitalized or date_first_hospitalized was estimated from doubling_time.

This likely causes an underestimate in growth rate for small marked share, because a single hospitalized patient represents a larger change from zero than in larger market shares.

This shows up later in test_model_cumulative_census:
```
# TODO: is 1.0 for ceil function?
diff = admits.hospitalized[1:-1] - (
0.05 * 0.05 * (raw_df.infected[1:-1] + raw_df.recovered[1:-1]) - 1.0
)
```

Missing a patient during in build_dispositions_df:
```
def build_dispositions_df(
raw_df: pd.DataFrame,
rates: Dict[str, float],
market_share: float,
current_date: datetime,
) -> pd.DataFrame:
"""Build dispositions dataframe of patients adjusted by rate and market_share."""
patients = raw_df.infected + raw_df.recovered
day = raw_df.day
return pd.DataFrame({
"day": day,
"date": day.astype('timedelta64[D]') + np.datetime64(current_date),
**{
key: patients * rate * market_share
for key, rate in rates.items()
}
})
```

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.