CodeForPhilly / CodeForPhilly/balancer-main

Improve CI Pipelines: Linting, Formatting, Pre-commits, and Testing

Aperta
#458 0 commenti 0 reazioni 1 assegnatario Rivendicata da @sahilds1 Vedi su GitHub
Documentation
Lingua principale
TypeScript
Stelle
21
Fork
19
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

The current CI workflows in `.github/workflows/frontend-ci.yml` and `.github/workflows/python-app.yml` are missing several critical quality checks.

### Proposed Improvements:

#### 1. Frontend (`frontend-ci.yml`)
- **Strict Checks:** Remove `continue-on-error: true` from `Lint` and `Build` steps so that PRs cannot be merged with failures.
- **Formatting:** Add a step to verify formatting using Prettier (e.g., `npx prettier --check .`).
- **Testing:** Add a step to run tests if any exist (e.g., `npm test`).
- **Dependency Cache:** Ensure Node.js cache is working correctly (already present but should be verified).

#### 2. Python Backend (`python-app.yml`)
- **Formatting:** Add Ruff formatting check (`ruff format --check`).
- **Testing:** Add a step to run Django tests (`python manage.py test`).
- **Branch Triggers:** Update branch triggers to include `develop` or the main branch (currently points to `listOfMed`).
- **Linting:** Improve Ruff linting configuration or ensure it's running with the desired rules.

#### 3. General Enhancements
- **Pre-commit Hooks:** Integrate `pre-commit` into CI to ensure all hooks pass before merging.
- **Consistency:** Align branch triggers across all CI workflows.

### Why is this needed?
To ensure code quality, consistency, and prevent regressions from being merged into the main branches.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.