CodeEditApp / CodeEditApp/CodeEdit
🐞 Open Quickly doesn't exactly 'close'
- Lenguaje dominante
- Swift
- Estrellas
- 23k
- Forks
- 1.2k
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
### Description
Open Quickly is not exactly 'closed' when its modal is removed. The expected behavior is for it to be reopened with its last search query, but having its search results remain in the background may not be intentional. For example, the resources used to load the previews are not released.
It seems xcode recomputes the query when Open Quickly is reopened. It may just be the enter animation but since the selected list item is reset when reopening, I think it recomputes.
### To Reproduce
1. `cmd` `shift` `o` to show Open Quickly.
2. Enter a search term.
3. You can also move down the list and move the text cursor to the left.
4. Press `escape` or click elsewhere to close the Open Quickly modal
5. reopen Open Quickly
### Expected Behavior
Open quickly should teardown (but cache the query) when closed, and then recompute the results when opened again.
### Version Information
CodeEdit: 0.2.0-dev (39)
macOS: 14.5
Xcode: 15.4
### Additional Context
_No response_
### Screenshots
CodeEdit:
https://github.com/user-attachments/assets/0ad94c0b-cb4a-417a-b85c-531221113b53
Xcode:
https://github.com/user-attachments/assets/c33528da-881b-46a5-a888-bff48b37a97e
Guía de contribución
Línea de trabajo
Empieza reproduciendo la secuencia de Open Quickly descrita: buscar, navegar o mover el cursor, cerrar el modal y volver a abrirlo. Inspecciona la implementación de Open Quickly responsable de la eliminación del modal, las consultas almacenadas en caché, los elementos seleccionados, los resultados de búsqueda y los recursos de preview. Se considera terminado cuando cerrar desmonta los resultados y libera los recursos de preview, mientras que volver a abrir conserva la consulta y vuelve a calcular los resultados.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- swift
- Área
- desktop
- Tipo de issue
- Error
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 42/100