CodeEditApp / CodeEditApp/CodeEdit

🐞 `cmd+delete` for deleting terminal become inactive after trying to delete a file with the shortcut

Open
#1,343 0 comments 0 reactions 1 assignee Claimed by @Wouter01 View on GitHub
bug
Dominant language
Swift
Stars
23k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

### Description

In PR #1329, some improvements on the focus system are added so commands like `cmd+delete` for deleting current terminal or selected file can be handled more easily. But, after the user selects a file and try to use `cmd+delete` to delete a file (which will not work because it's not implemented), `cmd+delete` for deleting the terminal will also stop working.

### To Reproduce

1. Open a project with CodeEdit
2. Select a terminal tab
3. Use `cmd+delete` to delete the terminal (it will work as intended)
4. Select a file
5. Use `cmd+delete` to delete the file (it will not work because it's yet to be implemented)
6. Select a terminal tab again
7. Use `cmd+delete` to delete the terminal (this time it will stop working)

### Expected Behavior

The terminal should be deleted.

### Version Information

CodeEdit: commit 6f3915990f317ce59fac58ae4a787bd9e4b0cc22
macOS: macOS Sonoma 14.0 Beta (23A5257q)
Xcode: 15.0 beta (15A5160n)

### Additional Context

_No response_

### Screenshots

https://github.com/CodeEditApp/CodeEdit/assets/72877496/f1d7b4f4-6012-4166-ac54-b6b24012fb6b

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.