CodeEditApp / CodeEditApp/CodeEdit

🐞 Incorrect focus ring shape for buttons.

未關閉
#1,144 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
bug
主要語言
Swift
星號
23k
分支
1.2k
PR 合併指標
30 天內沒有已合併 PR

描述

### Description

Focus ring shape for buttons are incorrect.

For AppKit controls, focus rings for buttons with images automatically get their shape according to the image content, or it could be arbitrarily drawn by implementing `NSCell.drawFocusRingMask(withFrame:in:)`.

For SwiftUI, current I have no idea how to implement such behavior. `View.contentShape(_:eoFill:)` may help, but unless we have a efficient way to convert SF Symbols to `CGPath`s. The [only article I could find](https://maheepk.net/posts/converting-sf-symbols-to-shapes/) utilizes `Vision.framework` to do this, which is too heavy I believe.

### To Reproduce

1. Enable keyboard navigation on system settings.
Screenshot 2023-03-12 at 15 59 12
2. Open CodeEdit and see the focus ring shape.

### Expected Behavior

Focus rings should be the same shape as the button image.

### Version Information

CodeEdit: Version 0.0.3-dev (30)
macOS: 13.3 Beta (22E5236f)
Xcode: 14.2.1

### Additional Context

_No response_

### Screenshots

Screenshot 2023-03-12 at 16 01 20

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。