CodeChain-io / CodeChain-io/codechain-sdk-js

SDK assumes networkID as tc if not specified.

未关闭
#405 0 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
TypeScript
星标
26
派生
14
PR 合并指标
30 天内没有已合并 PR

描述

Assuming `tc` as default `networkID` is not problem.

But in the first example code of [codechain sdk document](https://api.codechain.io/2.0.1/index.html),
`networkID` is not specified while constructing SDK object.

This might cause confusion because sdk also assumes `networkID` as `tc` in the case below.
```javascript
var sdk = new SDK({ server: "https://corgi-rpc.codechain.io" });
```

To set networkId to `wc`, we should specify it
```javascript
var sdk = new SDK({ server: "https://corgi-rpc.codechain.io"
networkId: "wc"});
```

So I think we should change document or change assuming logic.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。