CodeChain-io / CodeChain-io/codechain-sdk-go
Use custom JSON marshal instead of object duplication
- Lingua principale
- Go
- Stelle
- 5
- Fork
- 4
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
Currently, some of the Transaction-related objects have two forms, which implement normal type and for marshaling.
https://github.com/CodeChain-io/codechain-sdk-go/blob/6ad3e76c4dfba22b0867764b8c67500dce7518d2/core/transaction/signedTransaction.go#L11-L17
https://github.com/CodeChain-io/codechain-sdk-go/blob/6ad3e76c4dfba22b0867764b8c67500dce7518d2/core/transaction/signedTransaction.go#L19-L25
This implementation is from [codechain-sdk-js](https://github.com/CodeChain-io/codechain-sdk-js).
But since golang can implement custom marshaling function ([link1](http://choly.ca/post/go-json-marshalling/
)) ([link2](https://play.golang.org/p/CTmJhTiGAM)), I think duplication of the objects is unnecessary.
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Valutazione
Questa issue non è ancora stata valutata.