ClickHouse / ClickHouse/clickhouse-java

Block in NonBlockingInputStream

Offen
#2,297 2 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
bug client-v1 enhancement
Vorherrschende Sprache
Java
Sterne
1.6k
Forks
636
Ø Merge
2 T. 23 Std.
Gemergte PRs (30 T.)
29

Beschreibung

![Image](https://github.com/user-attachments/assets/4f8a9c5d-5ab7-4b99-84b4-0d02281d623b)

![Image](https://github.com/user-attachments/assets/dd02be80-b7ec-4789-b138-bb695248f8ba)

https://github.com/ClickHouse/clickhouse-java/blob/5758ec51f944dc1daaac4a85084346ee5f8e93bb/clickhouse-data/src/main/java/com/clickhouse/data/stream/NonBlockingInputStream.java

NonBlockingInputStream has a busy loop in it, which consumes 100% CPU while it waits for data from server. Not only does it block the NonBlockingInputStream, but also it does it in a resource intensive way.

### Describe the solution you'd like
Either add Thread.sleep(1) there or a more configurable wait strategy.

### Describe the alternatives you've considered
One can also change queue implementation from AdaptiveQueue to some other queue which supports blocking waiting. But it contradicts the expected non blocking behavior of this class anyway.

### Additional context
I am attaching a profile of my application collected by async profiler. One can see that about 86% of cpu time is spent in this place.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.