CacheControl / CacheControl/json-rules-engine

Rule Ts incorrect

Abierto
#253 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
JavaScript
Estrellas
3.1k
Forks
507
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

The `rule.js` recently refactored the `rule.event` property to `rule.ruleEvent` (80e84b3ada7df7fca20aba21e37d8b5ee4257023) but there were no corresponding updates to the types when using the types accessing the property directly does not work as expected.

Should the type use `rule.ruleEvent` or should it use accessors for the event?

js & ts are not my speciality but i think the 'event' property of the interface needs to have a `get function` & `set function` that are actually the `getEvent` and `setEvent` functions.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.