CacheControl / CacheControl/json-rules-engine

Rule Ts incorrect

Open
#253 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
3.1k
Forks
507
PR merge metrics
No merged PRs in 30d

Description

The `rule.js` recently refactored the `rule.event` property to `rule.ruleEvent` (80e84b3ada7df7fca20aba21e37d8b5ee4257023) but there were no corresponding updates to the types when using the types accessing the property directly does not work as expected.

Should the type use `rule.ruleEvent` or should it use accessors for the event?

js & ts are not my speciality but i think the 'event' property of the interface needs to have a `get function` & `set function` that are actually the `getEvent` and `setEvent` functions.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.