CSAILVision / CSAILVision/LabelMeAnnotationTool

svg draw using append does not work

Open
#20 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.5k
Forks
443
PR merge metrics
No merged PRs in 30d

Description

Hi all,

I also find that the current git version does not work on using svg drawing.
In annotationTools/js/plot.js, there are lots of draw functions, such as DrawPolygon, DrawPolyLines, ... all of these functions use $('#'+element_id).append("xxx");
However, it does not work at my side. By "not work", I mean these functions show no output on my screen. I use console.log to check what was contained in $('#'+element_id), and found that the append does not work.

So, I googled, and find a workaround by adding

var divName = String('#'+element_id+'_div');
if (divName != null) $(divName).html($(divName).html());

these two lines at the end of each these draw function.
It generally works, but I cannot believe this is the right way to go.

My question is that
is there any special setup I should follow?

My environment is macbook pro + safari/chrome, apache 2.4.

yours,
Luming

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in annotationTools/js/plot.js and inspect DrawPolygon, DrawPolyLines, and the other drawing functions that call append. Reproduce the missing SVG output in Safari or Chrome, then determine whether the issue is specific to the referenced element or append operation. Done means the drawing functions render without the reported html workaround.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.