CDCgov / CDCgov/dibbs-ecr-diff

Flesh out matching logic

Open
#58 1 comment 0 reactions 1 assignee View on GitHub

@DavidMcClatchey is already working on this.

Since Jun 10, 2026.

Dominant language
Python
Stars
1
Forks
0
Avg merge
3d 7h
Merged PRs (30d)
12

Description

What needs to be done

Review and refactor the matching logic that currently exists in the prototype.
Primarily in the match_children_ignore_order method inside of matching.py.

Why it needs to be done

We need this for our core matching logic.

Acceptance Criteria

  • Working with existing prototype code, review and refactor matching.py to match elements after keys have been generated for those elements. See matching.py.

Technical Notes

  • Development should be done on the david/prototype-diff branch to ensure new code still properly integrates with all of the prototype code that hasn't been fleshed out yet. Once this feature is complete, then a new branch should be created to merge only the files relevant to this feature into main.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.