Flesh out fallback key logic

Open
#57 2 comments 0 reactions 2 assignees View on GitHub

@DanielSass is already working on this.

Since Jun 17, 2026.

Assessment

This issue has not been assessed yet.

Description

What needs to be done

Generate fallback keys for CDA elements in an eICR wherever a stable key or narrative key cannot be generated.
Currently in cda_fallback_keys.py. The main fallback methods are soft_context_key and secondary_discriminator.

Why it needs to be done

We need this for our core matching logic.

Acceptance Criteria

  • Working with existing prototype code, review and refactor the code to generate a fallback key for sections that can neither be keyed by the stable_key method nor by narrative key methods. See cda_fallback_keys.py.

Technical Notes

  • Development should be done on the david/prototype-diff branch to ensure new code still properly integrates with all of the prototype code that hasn't been fleshed out yet. Once this feature is complete, then a new branch should be created to merge only the files relevant to this feature into main.
  • Double check if any of the methodology in the fallback keys is already overtaken, i.e. already handled, by any of the methodology of building a stable key or narrative key.
Dominant language
Python
Stars
1
Forks
0
Avg merge
3d 7h
Merged PRs (30d)
12

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from CDCgov/dibbs-ecr-diff

All issues in CDCgov/dibbs-ecr-diff

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.