CDCgov / CDCgov/PyRenew

`InfectionsWithFeedback` docstring has incorrect feedback sign

Open
#854 0 comments 1 reaction 1 assignee View on GitHub

@cdc-mitzimorris is already working on this.

Since Jul 10, 2026.

documentation
Dominant language
Python
Stars
29
Forks
9
Avg merge
9d 9h
Merged PRs (30d)
8

Description

The class docstring for InfectionsWithFeedback writes the Rt adjustment as exp(-gamma * recent_infections), but compute_infections_from_rt_with_feedback implements and documents it as exp(gamma * recent_infections).

This changes the interpretation of infection_feedback_strength:

  • negative gamma reduces effective Rt
  • positive gamma increases effective Rt

The class docstring should match infection_functions.py and the implementation.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.