CDCgov / CDCgov/PyRenew

Vectorize `r_approx_from_R`

Open
#486 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
29
Forks
9
Avg merge
9d 9h
Merged PRs (30d)
8

Description

As implemented, the logic here obtains a scalar $r$ from from scalar $\mathcal{R}$, mostly because I didn't want to think about array dimensions and broadcasting. Generalizing it should be relatively straightforward, but may need some tests. I think I'd prefer to spin that off.

Originally posted by @dylanhmorris in https://github.com/CDCgov/PyRenew/pull/482#discussion_r1970421768

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate r_approx_from_R and inspect how its scalar assumptions affect array dimensions and broadcasting. Add tests for array inputs and broadcasting behavior; done means the function accepts vector or array-valued ℛ while preserving the existing scalar behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.