CDCgov / CDCgov/PyRenew

Deprecate `record` for `DeterministicVariable`s

Open
#407 3 comments 1 reaction 1 assignee View on GitHub

@O957 is already working on this.

Since Sep 13, 2024.

clean up
Dominant language
Python
Stars
29
Forks
9
Avg merge
9d 9h
Merged PRs (30d)
8

Description

Originally posted by @damonbayer in https://github.com/CDCgov/PyRenew/issues/402#issuecomment-2302813581

DeterministicVariables should not have a record argument. Instead, they should take an optional name argument. If a name is supplied, the variable should always be recorded. If the name is omitted, then the variable should not be recorded.

For "composite RandomVariables containing multiple sites, each site should have an optional name argument, which determines whether the site is recorded.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.