Should `DeterministicVariable` be able to have an arbitrary `pytree` as their `vars` value?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 29
- Forks
- 9
- Avg merge
- 9d 9h
- Merged PRs (30d)
- 8
Description
We should discuss elsewhere whether
DeterministicVariables should be able to have an arbitrarypytreeas theirvarsvalue. I lean yes.I would also support renaming
varstovalue, for consistency withSampledValue.
Originally posted by @dylanhmorris in https://github.com/CDCgov/multisignal-epi-inference/pull/262#discussion_r1690428602
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Start by locating the definitions of DeterministicVariable and SampledValue, then trace how their vars and value fields are consumed. Done requires an agreed decision on arbitrary pytrees and whether vars should be renamed to value, with the affected behavior identified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100