CCExtractor / CCExtractor/ccextractor

Refactor: Move demuxer-related options from global ccx_options to ccx_demuxer struct

Aperta
#2,101 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
C
Stelle
903
Fork
589
Merge medio
3g 2h
PR unite (30g)
10

Descrizione

## Problem

Several functions in `src/lib_ccx/file_functions.c` rely on the global `ccx_options` struct for configuration values, specifically:

- `ccx_options.live_stream`
- `ccx_options.buffer_input`
- `ccx_options.input_source`
- `ccx_options.binary_concat`

This creates tight coupling between the demuxer logic and global application state.

## Current Behavior

Functions such as:

- `buffered_read_opt()`
- `switch_to_next_file()`
- `ccx_demuxer_open()`
- `ccx_demuxer_close()`

directly access the global `ccx_options` struct instead of receiving configuration through the demuxer context.

## Why This Is Problematic

- **Testability** — Functions relying on globals are difficult to unit test in isolation.
- **Encapsulation** — The demuxer's behavior depends on external state it does not own.
- **Thread safety** — Global state increases the risk of race conditions in multi-threaded scenarios.
- **Library reuse** — Tight coupling makes `lib_ccx` harder to use as a standalone library.

## Proposed Solution

- Add `live_stream`, `buffer_input`, `input_source`, and `binary_concat` fields to `struct ccx_demuxer`.
- Initialize these fields from `ccx_options` during demuxer initialization (e.g., in `init_demuxer()`).
- Update affected functions to read configuration from the demuxer context (`ctx->`) instead of the global `ccx_options`.

## Affected Files

- `src/lib_ccx/ccx_demuxer.h`
- `src/lib_ccx/ccx_demuxer.c`
- `src/lib_ccx/file_functions.c`

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.