Beakerboy / Beakerboy/VBA-SQL-Library
SQLSelect — LeftJoin/RightJoin ByRef type mismatch
- Lenguaje dominante
- VBA
- Estrellas
- 90
- Forks
- 18
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
SQLSelect: type LeftJoin/RightJoin params as String
- Component: `src/ClassModules/SQLSelect.cls` (around 120–143)
### Problem
- Untyped parameters (`Variant` ByRef) cause mismatches when passed into `AddJoin`.
### Snippet (actual)
```vb
Public Sub LeftJoin(sTable, sAlias, Optional sCondition As String = "")
AddJoin "LEFT OUTER", sTable, sAlias, sCondition
End Sub
Public Sub RightJoin(sTable, sAlias, Optional sCondition As String = "")
AddJoin "RIGHT OUTER", sTable, sAlias, sCondition
End Sub
```
### Expected
```vb
Public Sub LeftJoin(sTable As String, sAlias As String, Optional sCondition As String = "")
AddJoin "LEFT OUTER", sTable, sAlias, sCondition
End Sub
Public Sub RightJoin(sTable As String, sAlias As String, Optional sCondition As String = "")
AddJoin "RIGHT OUTER", sTable, sAlias, sCondition
End Sub
```
### Steps to Reproduce
1) Call `LeftJoin`/`RightJoin` with string literals under strict compilation.
### Actual
- Compile-time "ByRef argument type mismatch" in some contexts.
### Proposed Fix
- Type parameters as `String`.
---
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Línea de trabajo
Open src/ClassModules/SQLSelect.cls around lines 120–143 and inspect the LeftJoin and RightJoin declarations and their calls to AddJoin. Compile or reproduce the strict-compilation case using string literals; done means both methods compile without the ByRef argument type mismatch.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- sql
- Área
- databases
- Tipo de issue
- Error
- Dificultad
- 1/5
- Tiempo estimado
- Menos de una hora
- Estado de actividad
- Estancado
- Claridad
- Bien especificado
- Aptitud para principiantes
- 55/100