Baseflow / Baseflow/PhotoView

PhotoView in ViewPager "jumping" issue

Abierto
#421 2 comentarios 13 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Java
Estrellas
18.8k
Forks
3.9k
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Hello, I have noticed an issue when using PhotoView with ViewPager. When zoomed in and you try to navigate to the next page, the PhotoView is first scrolled to the edge as expected, but after that the next ViewPager page just sort of jumps into view. I also recorded a gif to demonstrate this issue: https://media.giphy.com/media/xyH3Dqr5mZroI/giphy.gif

I realise, that this is also ViewPager's (VP) fault because it intercepts the DOWN event which is actually meant for the PhotoView (PV) and when PV starts passing MOVE events to the VP then VP just thinks that the person has dragged the screen really fast.

Do you think this is something PV could address? I would suggest starting to pass MOVE events to the parent only if PV is already scrolled to the edge when the DOWN event occurs - then the DOWN event that VP intercepts would actually be with the correct X and Y.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Comienza reproduciendo la interacción reportada con PhotoView dentro de Android ViewPager, utilizando el GIF enlazado como referencia del comportamiento. Lee las rutas de gestión de eventos táctiles de PhotoView y ViewPager y, a continuación, verifica que navegar desde un borde ampliado ya no provoque que la página siguiente salte.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
android, java
Área
mobile-dev
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.