BHoM / BHoM/HTTP_Toolkit

BatchRequest not working as expected

Abierto
#72 0 comentarios 0 reacciones 1 asignado Reclamado por @rolyhudson Ver en GitHub
type:bug
Lenguaje dominante
C#
Estrellas
2
Forks
1
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

#### Description:
Pull with BatchRequest fails:
![image](https://user-images.githubusercontent.com/6618854/134374166-6aea8efe-7d97-4987-ac9a-e3eacc4be0f9.png)

#### Steps to reproduce:
[Try the script here](https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/HTTP_Toolkit/%2372BatchRequest.gh?csf=1&web=1&e=yXnvG5)
I think this line https://github.com/BHoM/HTTP_Toolkit/blob/6f94727e931ee93c3b55f4c4d983bb9cae9273db/HTTP_Adapter/AdapterActions/Pull.cs#L70
Should have `ActionConfig` as the input parameter not HTTPConfig.
Otherwise the Pull method drops through to the fallback method

**Edit:**
I did a quick test to make the change as described above. Pull with a BatchRequest just hangs...
Maybe the concurrent set up is not quite right for the method?

#### Expected behaviour:

#### Test file(s):

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.