BHoM / BHoM/HTTP_Toolkit

BatchRequest not working as expected

Open
#72 0 comments 0 reactions 1 assignee Claimed by @rolyhudson View on GitHub
type:bug
Dominant language
C#
Stars
2
Forks
1
PR merge metrics
No merged PRs in 30d

Description

#### Description:
Pull with BatchRequest fails:
![image](https://user-images.githubusercontent.com/6618854/134374166-6aea8efe-7d97-4987-ac9a-e3eacc4be0f9.png)

#### Steps to reproduce:
[Try the script here](https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/HTTP_Toolkit/%2372BatchRequest.gh?csf=1&web=1&e=yXnvG5)
I think this line https://github.com/BHoM/HTTP_Toolkit/blob/6f94727e931ee93c3b55f4c4d983bb9cae9273db/HTTP_Adapter/AdapterActions/Pull.cs#L70
Should have `ActionConfig` as the input parameter not HTTPConfig.
Otherwise the Pull method drops through to the fallback method

**Edit:**
I did a quick test to make the change as described above. Pull with a BatchRequest just hangs...
Maybe the concurrent set up is not quite right for the method?

#### Expected behaviour:

#### Test file(s):

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.