Azure / Azure/static-web-apps-cli

CLI doesn't produce a failure related exit code in case of failure

Abierto
#783 6 comentarios 8 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
TypeScript
Estrellas
668
Forks
156
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

**Describe the bug**
A clear and concise description of what the bug is.

Any error coming from running the CLI doesn't have an exit code that represents a failure. When I run the CLI directly (not by using the github actions action), I don't get an error from it. One example:

```
Run ./node_modules/.bin/swa deploy --no-use-keychain --config-name dev --env pr124

Welcome to Azure Static Web Apps CLI (1.1.4)

Using configuration "dev" from file:
/home/runner/work/repo/repo/swa-cli.config.json

Deploying front-end files from folder:
/home/runner/work/repo/repo/dist

Consider providing api-language and version using --api-language and --api-version flags,
otherwise default values apiLanguage: node and apiVersion: 16 will apply
Checking Azure session...
✔ Successfully logged into Azure!
✔ Saved project credentials in .env file.

Checking project "project" settings...
✔ Successfully setup project!

Deploying to environment: pr124

Found configuration file:
/home/runner/work/repo/repo/staticwebapp.config.json

Deploying project to Azure Static Web Apps...
Could not find StaticSitesClient local binary
- Downloading https://swalocaldeploy.azureedge.net/downloads/1.0.024941/linux/StaticSitesClient@1.0.024941
[swa] ✔ Downloading https://swalocaldeploy.azureedge.net/downloads/1.0.024941/linux/StaticSitesClient@1.0.024941
- Preparing deployment. Please wait...
✖ The content server has rejected the request with: BadRequest
✖ Reason: This Static Web App already has the maximum number of staging environments (3). Please remove one and try again.
```

**To Reproduce**
Steps to reproduce the behavior:

1. Use the SWA CLI manually in github actions
2. Run a command that will fail
3. The workflow will not fail

**Expected behavior**

I expected the CLI to exit with a code that represents a failure, so the workflow would fail.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Comienza en el punto de entrada ./node_modules/.bin/swa deploy y reproduce el fallo con el comando de deploy mostrado, utilizando la configuración de swa-cli.config.json y staticwebapp.config.json del informe. Rastrea cómo se devuelve el error de deployment indicado al proceso de CLI; el trabajo estará terminado cuando un deployment fallido produzca un código de salida distinto de cero y haga que el workflow falle.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
typescript
Área
cli
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
42/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.