Azure / Azure/data-api-builder

Update SerializationDeserialization tests to validate field names and not field count.

Abierto
#2,345 0 comentarios 0 reacciones 1 asignado Reclamado por @rusamant Ver en GitHub
testing usability validation
Lenguaje dominante
C#
Estrellas
1.5k
Forks
370
Merge medio
3 d 22 h
PR fusionados (30 d)
9

Descripción

Examples in SerializationDeserialization tests validate field count with magic numbers. If this number were to change and fail tests, we have no way of knowing which fields the tests were checking for.

```csharp
Assert.AreEqual(fields, 8); // what are the 8 fields??
Assert.AreEqual(fields, 5); // what are the 5 fields?
```

https://github.com/Azure/data-api-builder/blob/e8d9fcb9ac1c2aa8b47808b0a658a09e092545e0/src/Service.Tests/Unittests/SerializationDeserializationTests.cs#L428-L445

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.