Azure / Azure/data-api-builder

[Bug]: Multiple relationships to same entity causes empty sets

Aperta
#2,223 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
bug cri duplicate
Lingua principale
C#
Stelle
1.5k
Fork
370
Merge medio
3g 17h
PR unite (30g)
8

Descrizione

### What happened?

When an entity has multiple relationships to the same entity through different linking objects, this will cause the results to be null. Only objects related by all links will be in the result.

Repro:
```sql

drop table if exists dbo.RelationATable;
drop table if exists dbo.RelationBTable;
drop table if exists dbo.ParentTable;
drop table if exists dbo.ChildTable;
go

create table dbo.ParentTable
(
id int not null primary key,
parent_value varchar(100) not null
)
go

create table dbo.ChildTable
(
id int not null primary key,
child_value varchar(100) not null
)
go

create table dbo.RelationATable
(
id int IDENTITY(1,1) primary key,
parent_id int not null references dbo.ParentTable(id),
child_id int not null references dbo.ChildTable(id),
)
go
create table dbo.RelationBTable
(
id int IDENTITY(1,1) primary key,
parent_id int not null references dbo.ParentTable(id),
child_id int not null references dbo.ChildTable(id),
)
go
insert into dbo.ParentTable values
(1, 'Parent A'),
(2, 'Parent B'),
(3, 'Parent C'),
(4, 'Parent D'),
(5, 'Parent E')
go

insert into dbo.ChildTable values
(1, 'Child 1'),
(2, 'Child 2'),
(3, 'Child 3'),
(4, 'Child 4'),
(5, 'Child 5')
go
insert into dbo.RelationATable values
(1, 1),
(2, 2),
(3, 3 )
go
insert into dbo.RelationBTable values
(3, 3),
(2, 4),
(5 ,5)
go
```

Config file:

```json
{
"$schema": "https://github.com/Azure/data-api-builder/releases/download/v1.1.7/dab.draft.schema.json",
"data-source": {
"database-type": "mssql",
"connection-string": "@env('DATABASE_CONNECTION_STRING')",
"options": {
"set-session-context": false
}
},
"runtime": {
"rest": {
"enabled": true,
"path": "/api",
"request-body-strict": true
},
"graphql": {
"enabled": true,
"path": "/graphql",
"allow-introspection": true
},
"host": {
"cors": {
"origins": [],
"allow-credentials": false
},
"authentication": {
"provider": "StaticWebApps"
},
"mode": "development"
}
},
"entities": {
"Parent": {
"source": {
"object": "dbo.ParentTable",
"type": "table",
"key-fields": [
"id"
]
},
"graphql": {
"enabled": true,
"type": {
"singular": "Parent",
"plural": "Parents"
}
},
"rest": {
"enabled": true
},
"permissions": [
{
"role": "anonymous",
"actions": [
{
"action": "*"
}
]
}
],
"relationships": {
"relationToChildByA": {
"cardinality": "many",
"target.entity": "Child",
"source.fields": [
"id"
],
"target.fields": [
"id"
],
"linking.object": "dbo.RelationATable",
"linking.source.fields": [
"parent_id"
],
"linking.target.fields": [
"child_id"
]
},"relationToChildByB": {
"cardinality": "many",
"target.entity": "Child",
"source.fields": [
"id"
],
"target.fields": [
"id"
],
"linking.object": "dbo.RelationBTable",
"linking.source.fields": [
"parent_id"
],
"linking.target.fields": [
"child_id"
]
}
}
},
"Child": {
"source": {
"object": "dbo.ChildTable",
"type": "table",
"key-fields": [
"id"
]
},
"graphql": {
"enabled": true,
"type": {
"singular": "Child",
"plural": "Children"
}
},
"rest": {
"enabled": true
},
"permissions": [
{
"role": "anonymous",
"actions": [
{
"action": "*"
}
]
}
],
"relationships": {}
}
}
}
```

GraphQL query:

```graphql
query {
parents {
items {
relationToChildByA {
items {
child_value
}
}
relationToChildByB {
items {
child_value
}
}
}
}
}

```

The results return empty sets for relation A and B. Only Children with both relationships return any children:

```json
{
"data": {
"parents": {
"items": [
{
"relationToChildByA": {
"items": []
},
"relationToChildByB": {
"items": []
}
},
{
"relationToChildByA": {
"items": []
},
"relationToChildByB": {
"items": []
}
},
{
"relationToChildByA": {
"items": [
{
"child_value": "Child 3"
}
]
},
"relationToChildByB": {
"items": [
{
"child_value": "Child 3"
}
]
}
},
{
"relationToChildByA": {
"items": []
},
"relationToChildByB": {
"items": []
}
},
{
"relationToChildByA": {
"items": []
},
"relationToChildByB": {
"items": []
}
}
]
}
}
}
```

### Version

1.1.3-rc

### What database are you using?

Azure SQL

### What hosting model are you using?

Local (including CLI), Container Apps

### Which API approach are you accessing DAB through?

GraphQL

### Relevant log output

```Text
Azure.DataApiBuilder.Core.Resolvers.IQueryExecutor[0]
c7702ffe-7e5e-46f2-b101-11f281df401f Executing query: SELECT TOP 100 JSON_QUERY (COALESCE([table1_subq].[data], '[]')) AS [relationToChildByA], JSON_QUERY (COALESCE([table5_subq].[data], '[]')) AS [relationToChildByB] FROM [dbo].[ParentTable] AS [table0] OUTER APPLY (SELECT TOP 100 [table1].[child_value] AS [child_value] FROM [dbo].[ChildTable] AS [table1] INNER JOIN [dbo].[RelationATable] AS [table3] ON [table3].[child_id] = [table1].[id] INNER JOIN [dbo].[RelationBTable] AS [table4] ON [table4].[child_id] = [table1].[id] WHERE [table3].[parent_id] = [table0].[id] AND [table4].[parent_id] = [table0].[id] ORDER BY [table1].[id] ASC FOR JSON PATH, INCLUDE_NULL_VALUES) AS [table1_subq]([data]) OUTER APPLY (SELECT TOP 100 [table5].[child_value] AS [child_value] FROM [dbo].[ChildTable] AS [table5] INNER JOIN [dbo].[RelationATable] AS [table7] ON [table7].[child_id] = [table5].[id] INNER JOIN [dbo].[RelationBTable] AS [table8] ON [table8].[child_id] = [table5].[id] WHERE [table7].[parent_id] = [table0].[id] AND [table8].[parent_id] = [table0].[id] ORDER BY [table5].[id] ASC FOR JSON PATH, INCLUDE_NULL_VALUES) AS [table5_subq]([data]) WHERE 1 = 1 ORDER BY [table0].[id] ASC FOR JSON PATH, INCLUDE_NULL_VALUES
```

### Code of Conduct

- [X] I agree to follow this project's Code of Conduct

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Inizia riproducendo la query di relazione GraphQL su Azure SQL usando lo schema, i dati e il log SQL generato forniti. Traccia il motivo per cui ogni sottoquery di relazione include entrambe le tabelle di collegamento; il lavoro è completato quando la relazione A e la relazione B restituiscono i rispettivi elementi figli collegati indipendentemente, anziché solo l’intersezione.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
azure, csharp, graphql, sql
Ambito
api, backend-api-design, databases
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.