Azure / Azure/data-api-builder
create a sub-classes of DbConnectionParam for MsSql Vs Other databases
- Dominant language
- C#
- Stars
- 1.5k
- Forks
- 370
- Avg merge
- 3d 22h
- Merged PRs (30d)
- 9
Description
Might not be in this PR but something to consider: Can we create a sub-classes of DbConnectionParam for MsSql Vs Other databases (like `MsSqlDbConnectionParam`) and create parameter objects for sub-classes? Seems like for MsSql, just SqlDbType should be sufficient. Please open up an issue if this makes sense.
_Originally posted by @ayush3797 in https://github.com/Azure/data-api-builder/pull/2052#discussion_r1535456966_
Contributor guide
Research direction
Start by locating DbConnectionParam and the code that creates parameter objects, then compare how MsSql differs from other databases. Decide whether separate subclasses such as MsSqlDbConnectionParam are warranted and document the intended parameter behavior. Done means the design is agreed and the corresponding implementation scope is clear.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- backend-api-design, databases
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100