Azure / Azure/azure-storage-python
Issue when generating a url using sas token. Method file_service.make_file_url()
- Dominant language
- Python
- Stars
- 343
- Forks
- 243
- PR merge metrics
- No merged PRs in 30d
Description
### Which service(blob, file, queue) does this issue concern?
File share
### Which version of the SDK was used? Please provide the output of `pip freeze`.
azure-storage-file==2.0.1
azure-storage-common==2.0.0

### What problem was encountered?
https://github.com/Azure/azure-storage-python/blob/b8c5c9a1bc73065fd015c0fec75617cef263c6ee/azure-storage-file/azure/storage/file/fileservice.py#L233
When genrating a url using the method `make_file_url` passing a sas token, the generated url has two query strings ('?') instead of one.

The SaS Token generated on Azure portal starts with a query string.

### Have you found a mitigation/solution?
Yes. Remove the query string ('?') at line 233.
Note: for table service, please post the issue here instead: https://github.com/Azure/azure-cosmosdb-python.
Contributor guide
Research direction
Start in azure-storage-file/azure/storage/file/fileservice.py at line 233 and reproduce make_file_url() with a SAS token generated by the Azure portal. Verify that the resulting file URL contains one query-string delimiter rather than two. The issue does not name a test file, so inspect nearby URL-generation tests if present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- azure, python
- Domain
- api, cloud
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 42/100