Azure / Azure/azure-sdk-for-python

Clean up AnalyzeConversationAsyncLROPoller logic before GA/next beta

Aperta
#42,725 0 commenti 0 reazioni 1 assegnatario Rivendicata da @amber-Chen-86 Vedi su GitHub
Client Cognitive - Language
Lingua principale
Python
Stelle
5.6k
Fork
3.4k
Merge medio
2g 2h
PR unite (30g)
213

Descrizione

During PR review (https://github.com/Azure/azure-sdk-for-python/pull/42271), concerns were raised about the current patched poller implementation. Specifically:

**1. Last state handling**

- Right now _patch.py contains logic to capture the last operation state (poller._last_state) via a deserializer hook. Instead, we should move this logic into the custom poller itself by overloading base methods like wait() or result(). This keeps the patching minimal.

**2. Exposed details**

- poller.details currently includes errors and next_link. These should not be surfaced: if there's an error it should already get raised. And next_link is already handled by the ItemPaged that is returned in result.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.