Azure / Azure/azure-sdk-for-python

Clean up AnalyzeConversationAsyncLROPoller logic before GA/next beta

Open
#42,725 0 comments 0 reactions 1 assignee Claimed by @amber-Chen-86 View on GitHub
Client Cognitive - Language
Dominant language
Python
Stars
5.6k
Forks
3.4k
Avg merge
1d 21h
Merged PRs (30d)
193

Description

During PR review (https://github.com/Azure/azure-sdk-for-python/pull/42271), concerns were raised about the current patched poller implementation. Specifically:

**1. Last state handling**

- Right now _patch.py contains logic to capture the last operation state (poller._last_state) via a deserializer hook. Instead, we should move this logic into the custom poller itself by overloading base methods like wait() or result(). This keeps the patching minimal.

**2. Exposed details**

- poller.details currently includes errors and next_link. These should not be surfaced: if there's an error it should already get raised. And next_link is already handled by the ItemPaged that is returned in result.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.