Azure / Azure/azure-documentdb-java

Remove final from DTO's to support Unit Testing

Ouverte
#104 1 commentaire 1 réaction 0 personnes assignées Voir sur GitHub
enhancement
Langage dominant
Java
Étoiles
51
Forks
52
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

As a dev,
I want to write unit tests that mock the documentClient
so that I can unit test the behaviour of my classes.

Currently this is very hard thanks to the final classes returned by the documentClient.
i.e.

```
import com.microsoft.azure.documentdb.*;
import static org.assertj.core.api.Java6Assertions.assertThat;
import static org.mockito.Matchers.*;
import static org.mockito.Mockito.*;

...

private void givenAResponse(List response) {
DocumentClient documentClient = mock(DocumentClient.class);
FeedResponse feedResponse = mock(FeedResponse.class);
QueryIterable queryIterable = mock(QueryIterable.class);
when(documentClient.queryDocuments(
eq(CONNECTION_LINK),
any(String.class),
any(FeedOptions.class)))
.thenReturn(feedResponse);
when(feedResponse.getQueryIterable()).thenReturn(queryIterable);
when(queryIterable.toList()).thenReturn(response);
}
```

fails with:
```
org.mockito.exceptions.base.MockitoException:
Cannot mock/spy class com.microsoft.azure.documentdb.FeedResponse
Mockito cannot mock/spy following:
- final classes
```

Please can you remove 'final' from: FeedResponse and QueryIterable?

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.