Azure / Azure/azure-documentdb-java

Remove final from DTO's to support Unit Testing

Open
#104 1 comment 1 reaction 0 assignees View on GitHub
enhancement
Dominant language
Java
Stars
51
Forks
52
PR merge metrics
No merged PRs in 30d

Description

As a dev,
I want to write unit tests that mock the documentClient
so that I can unit test the behaviour of my classes.

Currently this is very hard thanks to the final classes returned by the documentClient.
i.e.

```
import com.microsoft.azure.documentdb.*;
import static org.assertj.core.api.Java6Assertions.assertThat;
import static org.mockito.Matchers.*;
import static org.mockito.Mockito.*;

...

private void givenAResponse(List response) {
DocumentClient documentClient = mock(DocumentClient.class);
FeedResponse feedResponse = mock(FeedResponse.class);
QueryIterable queryIterable = mock(QueryIterable.class);
when(documentClient.queryDocuments(
eq(CONNECTION_LINK),
any(String.class),
any(FeedOptions.class)))
.thenReturn(feedResponse);
when(feedResponse.getQueryIterable()).thenReturn(queryIterable);
when(queryIterable.toList()).thenReturn(response);
}
```

fails with:
```
org.mockito.exceptions.base.MockitoException:
Cannot mock/spy class com.microsoft.azure.documentdb.FeedResponse
Mockito cannot mock/spy following:
- final classes
```

Please can you remove 'final' from: FeedResponse and QueryIterable?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.