Azure / Azure/AzureGraph

`call_graph_url()` serializes POSIXct body fields as ambiguous, offset-less datetime strings

Abierto
#40 3 comentarios 1 reacción 0 asignados Ver en GitHub
Lenguaje dominante
R
Estrellas
38
Forks
22
Merge medio
2 d 8 h
PR fusionados (30 d)
1

Descripción

`call_graph_url()` serializes JSON request bodies with:

```
# R/call_graph.R, call_graph_url()
body <- jsonlite::toJSON(body[!null], auto_unbox = TRUE, digits = 22, null = "null")
```

This uses jsonlite's default POSIXt = "string" handling, which calls format()/as.character() on POSIXct values. That respects the object's tzone attribute but appends no UTC offset or "Z" suffix, so the resulting string is ambiguous about what instant it represents.

Microsoft Graph's OData Edm.DateTimeOffset fields expect an explicit ISO 8601 string with a Z or numeric offset (e.g. "2022-07-31T14:05:19Z"); sending a bare "2022-07-31 14:05:19" leaves Graph to guess the offset, which I think resolves against the site/tenant's regional timezone, silently shifting the stored instant away from the value the caller intended.

``` r
library(jsonlite)

x <- as.POSIXct(1659276319, origin = "1970-01-01", tz = "UTC")

# This mirrors call_graph_url()'s exact serialization call:
jsonlite::toJSON(
list(dateTimeField = x),
auto_unbox = TRUE,
digits = 22,
null = "null"
)
#> {"dateTimeField":"2022-07-31 14:05:19"}

# Confirming it's not just a formatting-style choice: jsonlite's "ISO8601"
# option has the same ambiguity, just with a "T" separator instead of a space
jsonlite::toJSON(list(dateTimeField = x), POSIXt = "ISO8601", auto_unbox = TRUE)
#> {"dateTimeField":"2022-07-31T14:05:19"}
# still no "Z"/offset

# The only unambiguous encoding requires explicit UTC formatting:
strftime(x, "%Y-%m-%dT%H:%M:%SZ", tz = "UTC")
#> [1] "2022-07-31T14:05:19Z"
```

Created on 2026-09-09 with [reprex v2.1.1](https://reprex.tidyverse.org)

**Expected:** A POSIXct value passed in a request body to call_graph_url() should serialize to an unambiguous ISO 8601 UTC string (...Z) matching what Graph's OData Edm.DateTimeOffset fields expect, regardless of the POSIXct object's tzone attribute or the caller's Sys.timezone().

**Actual:** The serialized string carries no UTC marker at all, so any Graph endpoint accepting a dateTime/DateTimeOffset field is handed an ambiguous value whenever a caller passes a native POSIXct.

**Suggested fix:** In call_graph_url(), before calling jsonlite::toJSON(), recursively convert any POSIXct (and Date) elements of body to explicit UTC ISO 8601 strings, e.g. `strftime(x, "%Y-%m-%dT%H:%M:%SZ", tz = "UTC")` for POSIXct and `strftime(x, "%Y-%m-%d", tz = "UTC")` for Date. Neither of jsonlite's built-in POSIXt options ("string", "ISO8601") is sufficient on their own, since neither appends a UTC offset.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Comienza en R/call_graph.R, en call_graph_url(), y reproduce la salida JSON mostrada en el issue con un valor POSIXct. Sigue cómo se serializan los valores del cuerpo de la solicitud y verifica después que los valores POSIXct se convierten en cadenas UTC ISO 8601 que terminan en Z, y que los valores Date usan el formato de fecha esperado, incluso cuando están anidados en el cuerpo.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
r
Área
api
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Activo
Claridad
Bien especificado
Aptitud para principiantes
75/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.