Azure-Samples / Azure-Samples/rag-data-openai-python-promptflow

build_index.py: index_name hardcoded in python file, .env AZUREAI_SEARCH_INDEX_NAME is ignored

Ouverte
#32 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Python
Étoiles
290
Forks
152
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

> Please provide us with the following information:
> ---------------------------------------------------------------

### This issue is for a: (mark with an `x`)
```
- [x] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)
```

### Minimal steps to reproduce
> in build_index.py the index name is hardcoded to "tutorial-index". However the index can also be specified via the .env file.
IMO the .env file should be read and only if there is no value, we should set a default value (to e.g. "tutorial-index)

hard coded value: https://github.com/Azure-Samples/rag-data-openai-python-promptflow/blob/7e8e6b04727364b2a608fd62b2efa1ffa322d266/tutorial/build_index.py#L44
env specified value: https://github.com/Azure-Samples/rag-data-openai-python-promptflow/blob/7e8e6b04727364b2a608fd62b2efa1ffa322d266/tutorial/sample.env#L12

### Any log messages given by the failure
>

### Expected/desired behavior
> index name should be read from value specified in the .env file

### OS and Version?
> Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)

### Versions
>

### Mention any other details that might be useful

> ---------------------------------------------------------------
> Thanks! We'll be in touch soon.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.