Automattic / Automattic/wp-codebox
Visual compare can screenshot before local stylesheets finish loading
- Lenguaje dominante
- TypeScript
- Estrellas
- 16
- Forks
- 4
- Merge medio
- 59 min
- PR fusionados (30 d)
- 131
Descripción
## Problem
`wordpress.visual-compare` can produce and classify a pixel diff while local linked stylesheets are still pending. `waitForVisualComparePaintReady()` caps its load wait and stylesheet wait at 10 seconds each, even when the command has a substantially larger wall timeout. Capture diagnostics then report pending stylesheets and low-confidence readiness, but the already-written screenshots continue into comparison as if they were conclusive.
This can create a false large layout delta when a pending stylesheet owns responsive visibility or geometry.
## Expected behavior
- Use a bounded stylesheet-readiness budget derived from the visual command timeout.
- Preserve enough wall time for settling, snapshots, screenshots, and diagnostics.
- Do not classify screenshots as conclusive visual evidence when required local stylesheets remain incomplete.
- Cover delayed local stylesheet loading with deterministic tests.
## Acceptance criteria
1. A local stylesheet that completes within the derived readiness budget is applied before capture.
2. A stylesheet that remains pending after the budget produces explicit incomplete-capture evidence rather than a misleading visual-diff classification.
3. Existing external-request isolation and overall command bounds remain intact.
## AI assistance
OpenAI GPT-5.6 Sol via OpenCode diagnosed the capture evidence, traced the owning implementation, and drafted this issue under human direction.
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Línea de trabajo
Comienza en waitForVisualComparePaintReady() y sigue la ruta de captura de wordpress.visual-compare, incluidos los diagnósticos, la estabilización, los snapshots y las capturas de pantalla. Prueba la carga retrasada de hojas de estilo locales con pruebas deterministas; se considera terminado cuando la preparación usa el tiempo de espera del comando sin romper el aislamiento de las solicitudes externas, y las hojas de estilo pendientes producen evidencia explícita de una captura incompleta en lugar de una clasificación concluyente de diferencia visual.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- typescript
- Área
- testing-qa
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Activo
- Claridad
- Bastante claro
- Aptitud para principiantes
- 68/100