Automattic / Automattic/VIP-Coding-Standards

4.0 | Remove previously deprecated code

Open
#849 1 comment 0 reactions 0 assignees View on GitHub
Breaking Change Type: Maintenance
Dominant language
PHP
Stars
261
Forks
44
Avg merge
19m
Merged PRs (30d)
1

Description

Removing the deprecated JS sniffs is tracked separately in #442.

List of deprecated code which should be removed in the next major:
- [ ] `WordPressVIPMinimum\Sniffs\Classes\DeclarationCompatibilitySniff::$checkClasses` - deprecated since VIPCS 3.1.0, see #858, related to #234.
- [ ] `WordPressVIPMinimum\Sniffs\Classes\DeclarationCompatibilitySniff::$checkClassesGroups` - deprecated since VIPCS 3.1.0, see #858, related to #234.
- [ ] The complete `WordPressVIPMinimum\Sniffs\Functions\DynamicCalls` sniff - deprecated since VIPCS 3.1.0, see #517 and #865
- [ ] `WordPressVIPMinimum\Sniffs\Performance\TaxonomyMetaInOptionsSniff::$option_functions` - deprecated since VIPCS 3.1.0, see #872, related to #234.
- [ ] `WordPressVIPMinimum\Sniffs\Security\ProperEscapingFunctionSniff::$url_attrs` - deprecated since VIPCS 2.3.1
- [ ] `WordPressVIPMinimum\Sniffs\Security\ProperEscapingFunctionSniff::$attr_endings` - deprecated since VIPCS 2.3.1
- [ ] `WordPressVIPMinimum\Sniffs\Security\ProperEscapingFunctionSniff::attr_expects_url)_` - deprecated since VIPCS 2.3.1
- [ ] `WordPressVIPMinimum\Sniffs\Security\ProperEscapingFunctionSniff::is_html_attr()` - deprecated since VIPCS 2.3.1

Contributor guide

Open the contributing guide

Research direction

Start by inspecting the listed WordPressVIPMinimum sniffs and their deprecated members, then review the referenced issues #858, #234, #517, #865, and #872 for scope and dependencies. The JavaScript sniffs are tracked separately in #442. Done means the listed deprecated PHP code is removed without including that separate work.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.