Automattic / Automattic/VIP-Coding-Standards
Report on code attempting to set image quality for VIP Go File service to 100
Open
Status: Awaiting feedback
Type: Enhancement
- Dominant language
- PHP
- Stars
- 261
- Forks
- 44
- Avg merge
- 19m
- Merged PRs (30d)
- 1
Description
We might want to start with something simple, prone to false positives. Eg.: reporting a Warning on every `$var['quality'] = 100;` or `$var['quality'] = '100'`.
Contributor guide
Research direction
Start by reviewing the existing PHP_CodeSniffer rules and their tests in VIP-Coding-Standards to find the pattern for reporting assignment warnings. Implement coverage for PHP code assigning 100 or '100' to a quality array key, including the stated false-positive-prone cases. Done means the rule reports those assignments consistently and the relevant tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100