ArduPilot / ArduPilot/ardupilot
Rover: proximity pre-arm check should only check forward and back
- Dominant language
- C++
- Stars
- 15.9k
- Forks
- 21.4k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 119
Description
Rover-3.3 includes object avoidance which is great but the [proximity sensor pre-arm check](https://github.com/ArduPilot/ardupilot/blob/master/APMrover2/AP_Arming.cpp#L107) checks for anything within 60cm.
First off, we shouldn't use a hard-coded 60cm distance. Instead it should use the Avoidance margin parameter ([declared here](https://github.com/ArduPilot/ardupilot/blob/master/libraries/AC_Avoidance/AC_Avoid.h#L139)) instead.
Also we should only check forward and backwards.
Contributor guide
Research direction
Start in APMrover2/AP_Arming.cpp at the proximity sensor pre-arm check around line 107, then read the avoidance margin declaration in libraries/AC_Avoidance/AC_Avoid.h. Update the check to use that margin and limit it to forward and backward directions; done means the pre-arm check no longer uses a fixed 60 cm distance or checks other directions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- embedded-iot, robotics
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100