ArduPilot / ArduPilot/ardupilot

Plane: Lidar/Rangefinder completly ignored on second approach when LAND_ABORT_DEG triggers landing restart

Open
#7,205 10 comments 0 reactions 0 assignees View on GitHub
Plane
Dominant language
C++
Stars
15.9k
Forks
21.4k
Avg merge
3d 17h
Merged PRs (30d)
119

Description

#### Issue details
When LAND_DEG_ABORT triggers an abort landing. On the second landing approach the lidar is completely ignored by the AP and only uses the new ground offset.
This is a major risk as many time just a tree or a pit gives the lidar the wrong value causing it to offset the ground level. Then on second approach it does not consider whatever the lidar report, just goes for new "virtual" ground level, like in Die Hard 2. This can and does end in hard crash into the ground, with plane skipping flare stage and all thinking that it is still airborne even tough it is long laying flat on the ground. Sometime even the props keep spinning.

#### Version
3.8.3 beta (started using lidar with 3.8 beta 05, the problem has be present from the start for me)

#### Platform
[ ] All
[ ] AntennaTracker
[ ] Copter
[ x ] Plane
[ ] Rover
[ ] Submarine

#### Airframe type
Fixed wing

#### Hardware type
Pixhawk2.1

#### Logs
[https://www.dropbox.com/s/rkrpaeid95d7z9f/2017-11-05%2016-48-54.bin?dl=0](url)

This is a major issue for me (has caused me multiple loss and damage) and took a long time to nail the what was really going wrong. Can I pay someone to fix this ASAP?
Ultimately sorting this (related issue out too would be very desired:[https://github.com/ArduPilot/ardupilot/issues/7052#issuecomment-342759892](url)

PS, the part of the code that controls manual landing abort/restart (your know.... with throttle to max), should also be verified if it has same bug. I never tested with that, but can imagine they would be using same subroutine to keep the code clean.

PS2: Here is some more post on this issue that let me to finding the culprit. Posted more similar logs there too [https://discuss.ardupilot.org/t/autolanding-multiple-code-issues-condition-for-uav-landed/22768](url)

Contributor guide

Open the contributing guide

Research direction

Review the linked flight log and trace the landing abort/restart path governed by LAND_DEG_ABORT, including the manual abort path mentioned in the report. Compare lidar handling on the first and second approaches; done means the second approach still considers lidar data and does not incorrectly skip the flare or remain in an airborne state.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
robotics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.